Conversation
…RenderPipeline Pretty much the same issue as d6937c4 but in the code for 1.21.5+ which no longer supports MCShader uses the new vanilla RenderPipeline mechanism instead. This fixes draws with custom shader on graphics drivers which do not order attributes by default by their order in the shader source code (mainly MacOS). Linear: EM-3161
Traben-0
approved these changes
Jul 28, 2025
Contributor
Traben-0
left a comment
Traben-0
left a comment
There was a problem hiding this comment.
lgtm, I cant verify this fixes macos myself though
Johni0702
deleted the
feature/em-3161-gradient-missing-on-cosmetic-previews-in-wardrobe-on-1215
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty much the same issue as d6937c4 but in the code for 1.21.5+ which no longer supports MCShader uses the new vanilla RenderPipeline mechanism instead.
This fixes draws with custom shader on graphics drivers which do not order attributes by default by their order in the shader source code (mainly MacOS).
Linear: EM-3161